linux-kernel - Re: [PATCH] s390/ap_bus: replace PTR_RET with PTR_ERR_OR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <9b1b260f-0caa-a199-3d22-a4c1d62e89f2@linux.ibm.com>
Date:   Thu, 19 Jul 2018 16:40:57 +0200
From:   Harald Freudenberger <freude@...ux.ibm.com>
To:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>,
        Martin Schwidefsky <schwidefsky@...ibm.com>,
        Heiko Carstens <heiko.carstens@...ibm.com>
Cc:     linux-s390@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] s390/ap_bus: replace PTR_RET with PTR_ERR_OR_ZERO

On 19.07.2018 06:42, Gustavo A. R. Silva wrote:
> PTR_RET is deprecated, use PTR_ERR_OR_ZERO instead.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
> ---
>  drivers/s390/crypto/ap_bus.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/s390/crypto/ap_bus.c b/drivers/s390/crypto/ap_bus.c
> index c0a6723..bf27fc4 100644
> --- a/drivers/s390/crypto/ap_bus.c
> +++ b/drivers/s390/crypto/ap_bus.c
> @@ -474,7 +474,7 @@ static int ap_poll_thread_start(void)
>  		return 0;
>  	mutex_lock(&ap_poll_thread_mutex);
>  	ap_poll_kthread = kthread_run(ap_poll_thread, NULL, "appoll");
> -	rc = PTR_RET(ap_poll_kthread);
> +	rc = PTR_ERR_OR_ZERO(ap_poll_kthread);
>  	if (rc)
>  		ap_poll_kthread = NULL;
>  	mutex_unlock(&ap_poll_thread_mutex);
> @@ -1242,7 +1242,7 @@ static int __init ap_module_init(void)
>  
>  	/* Create /sys/devices/ap. */
>  	ap_root_device = root_device_register("ap");
> -	rc = PTR_RET(ap_root_device);
> +	rc = PTR_ERR_OR_ZERO(ap_root_device);
>  	if (rc)
>  		goto out_bus;
>  

Reviewed-by: Harald Freudenberger <freude@...ux.ibm.com>