linux-kernel - Re: [PATCH v3 2/4] x86/boot: Add acpitb.c to parse acpi tables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.1807191720270.1693@nanos.tec.linutronix.de>
Date:   Thu, 19 Jul 2018 17:22:35 +0200 (CEST)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Chao Fan <fanc.fnst@...fujitsu.com>
cc:     linux-kernel@...r.kernel.org, x86@...nel.org, hpa@...or.com,
        mingo@...hat.com, bhe@...hat.com, keescook@...omium.org,
        yasu.isimatu@...il.com, indou.takao@...fujitsu.com,
        lcapitulino@...hat.com, caoj.fnst@...fujitsu.com,
        douly.fnst@...fujitsu.com
Subject: Re: [PATCH v3 2/4] x86/boot: Add acpitb.c to parse acpi tables

On Tue, 17 Jul 2018, Chao Fan wrote:
> +
> +/* Search efi table for rsdp table. */
> +static bool efi_get_rsdp_addr(acpi_physical_address *rsdp_addr)
> +{
> +	efi_system_table_t *systab;
> +	bool find_rsdp = false;
> +	bool acpi_20 = false;
> +	bool efi_64 = false;
> +	void *config_tables;
> +	struct efi_info *e;
> +	char *sig;
> +	int size;
> +	int i;
> +
> +#ifndef CONFIG_EFI
> +	return false;
> +#endif

Please no. Wrap the whole function into CONFIG_EFI annd have a stub for the
non EFI case returning false.

Thanks,

	tglx