linux-kernel - Re: [PATCH] pty: fix O

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180719171859.sn6a7n2mhmyx7mvs@mikami>
Date:   Fri, 20 Jul 2018 03:18:59 +1000
From:   Aleksa Sarai <asarai@...e.de>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jslaby@...e.com>, linux-kernel@...r.kernel.org,
        Arnd Bergmann <arnd@...db.de>,
        Eric W Biederman <ebiederm@...ssion.com>
Subject: Re: [PATCH] pty: fix O_CLOEXEC for TIOCGPTPEER

On 2018-07-19, Matthijs van Duin <matthijsvanduin@...il.com> wrote:
> It was being ignored because the flags were not passed to fd allocation.
> 
> Fixes: 54ebbfb16034 ("tty: add TIOCGPTPEER ioctl")

Acked-by: Aleksa Sarai <asarai@...e.de>

> Signed-off-by: Matthijs van Duin <matthijsvanduin@...il.com>
> ---
>  drivers/tty/pty.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/pty.c b/drivers/tty/pty.c
> index b0e2c4847a5d..678406e0948b 100644
> --- a/drivers/tty/pty.c
> +++ b/drivers/tty/pty.c
> @@ -625,7 +625,7 @@ int ptm_open_peer(struct file *master, struct tty_struct *tty, int flags)
>  	if (tty->driver != ptm_driver)
>  		return -EIO;
>  
> -	fd = get_unused_fd_flags(0);
> +	fd = get_unused_fd_flags(flags);
>  	if (fd < 0) {
>  		retval = fd;
>  		goto err;

-- 
Aleksa Sarai
Senior Software Engineer (Containers)
SUSE Linux GmbH
<https://www.cyphar.com/>

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)