linux-kernel - Re: [PATCH v11 7/9] cpuset: Expose cpus.effective and mems.effective on cgroup v2 root

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 19 Jul 2018 13:38:13 -0400
From:   Waiman Long <longman@...hat.com>
To:     Tejun Heo <tj@...nel.org>, Peter Zijlstra <peterz@...radead.org>
Cc:     Li Zefan <lizefan@...wei.com>,
        Johannes Weiner <hannes@...xchg.org>,
        Ingo Molnar <mingo@...hat.com>, cgroups@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org,
        kernel-team@...com, pjt@...gle.com, luto@...capital.net,
        Mike Galbraith <efault@....de>, torvalds@...ux-foundation.org,
        Roman Gushchin <guro@...com>,
        Juri Lelli <juri.lelli@...hat.com>,
        Patrick Bellasi <patrick.bellasi@....com>
Subject: Re: [PATCH v11 7/9] cpuset: Expose cpus.effective and mems.effective
 on cgroup v2 root

On 07/19/2018 01:25 PM, Tejun Heo wrote:
> Hello, Waiman.
>
> On Thu, Jul 19, 2018 at 01:22:36PM -0400, Waiman Long wrote:
> ...
>> Do you want a way at the parent level to take CPUs away from child
>> partitions? The "cpus.subpart" file can probably be used also for this
>> purpose, but we have to decide what taking CPUs away from child
>> partition means. Does that mean automatically turn off the partition
>> flag in the children if there is no CPU left in the partition? There are
> Yeah, I think so.  That's what we do when cpuset.cpus or mems go empty
> - ignoring the config.
>
>> some implementation details that need to be fleshed out. I would prefer
>> not doing this as this will complicate the code without too much benefit
>> that I can see.
> So, given how long this has been dragging along and it isn't yet super
> clear to me why this needs to be fully hierarchical, I'd actually
> prefer just restricting it to the first level children.
>
> Thanks.
>
Yes, I would prefer to check in the v11 cpuset patch as it is today,
including the incremental patch to limit partition to first level child
minus the debug patch. I do need to make cpuset v2 enabled ASAP.

This will give me more times to work on extending partition to be
hierarchical if the need arises as well as other cpuset v2 features. We
usually can't get all the things right in one single step.

Peter, are you OK with that? I can promise you that I will work to make
this happen at a later date if you really want it.

Cheers,
Longman