linux-kernel - Re: [PATCH v2 3/7] iio: tsl2772: add support for reading power settings from device tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180720173635.GA21241@rob-hp-laptop>
Date:   Fri, 20 Jul 2018 11:36:35 -0600
From:   Rob Herring <robh@...nel.org>
To:     Brian Masney <masneyb@...tation.org>
Cc:     jic23@...nel.org, mark.rutland@....com, andy.gross@...aro.org,
        david.brown@...aro.org, linux-iio@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-msm@...r.kernel.org, linux-soc@...r.kernel.org,
        jonathan@...ek.ca, jmaneyrol@...ensense.com, knaack.h@....de,
        lars@...afoo.de, pmeerw@...erw.net, mkelly@...o.com,
        fischerdouglasc@...il.com, bshah@....org, ctatlor97@...il.com,
        drew.paterson@....com
Subject: Re: [PATCH v2 3/7] iio: tsl2772: add support for reading power
 settings from device tree

On Tue, Jul 17, 2018 at 04:41:54AM -0400, Brian Masney wrote:
> This patch adds support for optionally reading the prox_diode and
> prox_power settings from device tree. This was tested using a LG
> Nexus 5 (hammerhead) which requires a different diode than the driver
> default for the IR LED.
> 
> Signed-off-by: Brian Masney <masneyb@...tation.org>
> ---
> The next patch in the series removes the tsl2772 driver from the
> trivial-devices.txt file. I separated it out so that change can go
> through device tree.
> 
>  .../devicetree/bindings/iio/light/tsl2772.txt | 39 +++++++++++++++++++

Please split DT bindings to separate patch.

>  drivers/iio/light/tsl2772.c                   | 16 ++++++++
>  include/dt-bindings/iio/amstaos,tsl2772.h     | 24 ++++++++++++
>  3 files changed, 79 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/light/tsl2772.txt
>  create mode 100644 include/dt-bindings/iio/amstaos,tsl2772.h
> 
> diff --git a/Documentation/devicetree/bindings/iio/light/tsl2772.txt b/Documentation/devicetree/bindings/iio/light/tsl2772.txt
> new file mode 100644
> index 000000000000..ab553d52b9fc
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/light/tsl2772.txt
> @@ -0,0 +1,39 @@
> +* AMS/TAOS ALS and proximity sensor
> +
> +Required properties:
> +
> +  - compatible: Should be one of
> +		"amstaos,tsl2571"
> +		"amstaos,tsl2671"
> +		"amstaos,tmd2671"
> +		"amstaos,tsl2771"
> +		"amstaos,tmd2771"
> +		"amstaos,tsl2572"
> +		"amstaos,tsl2672"
> +		"amstaos,tmd2672"
> +		"amstaos,tsl2772"
> +		"amstaos,tmd2772"
> +  - reg: the I2C address of the device
> +
> +Optional properties:
> +
> +  - amstaos,prox_diode - must be TSL2772_DIODE0, TSL2772_DIODE1, or
> +                         TSL2772_DIODE_BOTH.

s/_/-/

> +  - amstaos,prox_power - must be TSL2772_100_mA, TSL2772_50_mA, TSL2772_25_mA,
> +                         or TSL2772_13_mA.

I wonder if this should be common. Perhaps we should use the existing 
'led-max-microamp' as this is setting the current for an IR LED.

And while called 'power' this setting is current.

> +  - interrupt-parent: should be the phandle for the interrupt controller

Don't need to document this. It's implied by interrupts (and could be in 
a parent node).

> +  - interrupts: the sole interrupt generated by the device
> +
> +  Refer to interrupt-controller/interrupts.txt for generic interrupt client
> +  node bindings.
> +
> +Example:
> +
> +#include <dt-bindings/iio/amstaos,tsl2772.h>
> +
> +tsl2772@39 {
> +	compatible = "amstaos,tsl2772";
> +	reg = <0x39>;
> +	interrupts-extended = <&msmgpio 61 IRQ_TYPE_EDGE_FALLING>;
> +	amstaos,prox_diode = <TSL2772_DIODE0>;
> +};