linux-kernel - Re: [PATCH 1/2] gpiolib: don't allow userspace to set values of input lines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdayVPE9bzuDLp-WC0qA360JdFrUwgcDuDjuvjEk82ZKLQ@mail.gmail.com>
Date:   Fri, 20 Jul 2018 22:33:48 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Bartosz Golaszewski <brgl@...ev.pl>
Cc:     "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] gpiolib: don't allow userspace to set values of input lines

On Mon, Jul 16, 2018 at 4:13 PM Bartosz Golaszewski <brgl@...ev.pl> wrote:
> 2018-07-16 15:40 GMT+02:00 Linus Walleij <linus.walleij@...aro.org>:
> > On Mon, Jul 16, 2018 at 10:34 AM Bartosz Golaszewski <brgl@...ev.pl> wrote:
> >
> >> User space can currently both read and set values of input lines using
> >> the character device. This was not allowed by the old sysfs interface
> >> nor is it a correct behavior.
> >>
> >> Check the first descriptor in the set for the OUT flag when asked to
> >> set values and return -EPERM if the line is input.
> >>
> >> Signed-off-by: Bartosz Golaszewski <brgl@...ev.pl>
> >
> > Patch applied! Thanks for fixing this.
>
> Thanks. Do you think we should Cc stable on that one?

Nah. It's not a regression. (Not like things that worked before
stopped working.)

Yours,
Linus Walleij