linux-kernel - Re: [PATCH] i2c: exynos5: Describe the hardware variant for readability

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180720221546.obccridrqavnlzfn@ninjato>
Date:   Sat, 21 Jul 2018 00:15:46 +0200
From:   Wolfram Sang <wsa@...-dreams.de>
To:     Krzysztof Kozlowski <krzk@...nel.org>
Cc:     Kukjin Kim <kgene@...nel.org>, Andrzej Hajda <a.hajda@...sung.com>,
        Andi Shyti <andi@...zian.org>, linux-i2c@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] i2c: exynos5: Describe the hardware variant for
 readability

On Wed, Jul 18, 2018 at 09:54:04PM +0200, Krzysztof Kozlowski wrote:
> The driver supports multiple hardware variants of Exynos I2C controller
> which differ in FIFO depth, handling of interrupts and bus recovery in
> HSI2C_MASTER_ST_LOSE state.
> 
> The difference in variant was a single bit set for Exynos7 variants and
> implicit lack of this bit for other variants.
> 
> Make each variant explicit which also fixes the GCC warning about
> documentation:
> 
>     drivers/i2c/busses/i2c-exynos5.c:223: warning: Function parameter or member 'hw' not described in 'exynos_hsi2c_variant'
> 
> No change in functionality.
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>

Applied to for-next, thanks!


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)