linux-kernel - Re: [PATCH V2] spi: spi-geni-qcom: Add SPI driver support for GENI based QUP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 21 Jul 2018 06:45:36 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Dilip Kota <dkota@...eaurora.org>
Cc:     kbuild-all@...org, timur@...eaurora.org, swboyd@...omium.org,
        broonie@...nel.org, mka@...omium.org, linux-kernel@...r.kernel.org,
        linux-spi@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        Girish Mahadevan <girishm@...eaurora.org>,
        Karthikeyan Ramasubramanian <kramasub@...eaurora.org>,
        Sagar Dharia <sdharia@...eaurora.org>,
        Dilip Kota <dkota@...eaurora.org>
Subject: Re: [PATCH V2] spi: spi-geni-qcom: Add SPI driver support for GENI
 based QUP

Hi Girish,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on spi/for-next]
[also build test WARNING on v4.18-rc5 next-20180720]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Dilip-Kota/spi-spi-geni-qcom-Add-SPI-driver-support-for-GENI-based-QUP/20180721-034916
base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
config: i386-allmodconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All warnings (new ones prefixed by >>):

   In file included from drivers/spi/spi-geni-qcom.c:11:0:
   drivers/spi/spi-geni-qcom.c: In function 'spi_geni_prepare_transfer_hardware':
   include/linux/qcom-geni-se.h:238:9: error: 'version' undeclared (first use in this function); did you mean 'vm_region'?
     step = version & HW_VER_STEP_MASK; \
            ^
>> drivers/spi/spi-geni-qcom.c:256:3: note: in expansion of macro 'geni_se_get_wrapper_version'
      geni_se_get_wrapper_version(se, major, minor, step);
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/qcom-geni-se.h:238:9: note: each undeclared identifier is reported only once for each function it appears in
     step = version & HW_VER_STEP_MASK; \
            ^
>> drivers/spi/spi-geni-qcom.c:256:3: note: in expansion of macro 'geni_se_get_wrapper_version'
      geni_se_get_wrapper_version(se, major, minor, step);
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~

vim +/geni_se_get_wrapper_version +256 drivers/spi/spi-geni-qcom.c

   233	
   234	static int spi_geni_prepare_transfer_hardware(struct spi_master *spi)
   235	{
   236		struct spi_geni_master *mas = spi_master_get_devdata(spi);
   237		struct geni_se *se = &mas->se;
   238	
   239		if (!mas->setup) {
   240			int proto = geni_se_read_proto(se);
   241			unsigned int major;
   242			unsigned int minor;
   243			unsigned int step;
   244	
   245			if (proto != GENI_SE_SPI) {
   246				dev_err(mas->dev, "Invalid proto %d\n", proto);
   247				return -ENXIO;
   248			}
   249			mas->tx_fifo_depth = geni_se_get_tx_fifo_depth(se);
   250			mas->rx_fifo_depth = geni_se_get_rx_fifo_depth(se);
   251			mas->tx_fifo_width = geni_se_get_tx_fifo_width(se);
   252			geni_se_init(se, 0x0, (mas->tx_fifo_depth - 2));
   253			mas->oversampling = 1;
   254			/* Transmit an entire FIFO worth of data per IRQ */
   255			mas->tx_wm = 1;
 > 256			geni_se_get_wrapper_version(se, major, minor, step);
   257			if ((major == 1) && (minor == 0))
   258				mas->oversampling = 2;
   259			mas->setup = 1;
   260		}
   261		return 0;
   262	}
   263	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (64141 bytes)