linux-kernel - Re: [PATCH] mm: adjust max read count in generic_file_buffered

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180720161429.d63dccb9f66799dc0ff74dba@linux-foundation.org>
Date:   Fri, 20 Jul 2018 16:14:29 -0700
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     Jan Kara <jack@...e.cz>
Cc:     Chengguang Xu <cgxu519@....com>, mgorman@...hsingularity.net,
        jlayton@...hat.com, ak@...ux.intel.com, mawilcox@...rosoft.com,
        tim.c.chen@...ux.intel.com, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        Al Viro <viro@...IV.linux.org.uk>
Subject: Re: [PATCH] mm: adjust max read count in
 generic_file_buffered_read()

On Thu, 19 Jul 2018 10:58:12 +0200 Jan Kara <jack@...e.cz> wrote:

> On Thu 19-07-18 16:17:26, Chengguang Xu wrote:
> > When we try to truncate read count in generic_file_buffered_read(),
> > should deliver (sb->s_maxbytes - offset) as maximum count not
> > sb->s_maxbytes itself.
> > 
> > Signed-off-by: Chengguang Xu <cgxu519@....com>
> 
> Looks good to me. You can add:
> 
> Reviewed-by: Jan Kara <jack@...e.cz>

Yup.

What are the runtime effects of this bug?