linux-kernel - [PATCH] x86: use PTR_ERR_OR_ZERO to fix ptr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 20 Jul 2018 15:32:13 +0800
From:   YueHaibing <yuehaibing@...wei.com>
To:     <tglx@...utronix.de>, <mingo@...hat.com>, <hpa@...or.com>
CC:     <linux-kernel@...r.kernel.org>, <x86@...nel.org>,
        <kstewart@...uxfoundation.org>, <gregkh@...uxfoundation.org>,
        <pombredanne@...b.com>, YueHaibing <yuehaibing@...wei.com>
Subject: [PATCH] x86: use PTR_ERR_OR_ZERO to fix ptr_ret.cocci warning

ptr_ret.cocci warnings:
  arch/x86/kernel/pcspeaker.c:12:8-14: WARNING: PTR_ERR_OR_ZERO can be used

use PTR_ERR_OR_ZERO rather than an open-code version to fix this.

Signed-off-by: YueHaibing <yuehaibing@...wei.com>
---
 arch/x86/kernel/pcspeaker.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/pcspeaker.c b/arch/x86/kernel/pcspeaker.c
index da5190a..4a710ff 100644
--- a/arch/x86/kernel/pcspeaker.c
+++ b/arch/x86/kernel/pcspeaker.c
@@ -9,6 +9,6 @@ static __init int add_pcspkr(void)
 
 	pd = platform_device_register_simple("pcspkr", -1, NULL, 0);
 
-	return IS_ERR(pd) ? PTR_ERR(pd) : 0;
+	return PTR_ERR_OR_ZERO(pd);
 }
 device_initcall(add_pcspkr);
-- 
2.7.0