linux-kernel - Re: [PATCH v3 5/6] KVM: X86: Add NMI support to PV IPIs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <825c953c-ec48-84cf-f1ca-bdee5d327427@redhat.com>
Date:   Fri, 20 Jul 2018 10:04:23 +0200
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Wanpeng Li <kernellwp@...il.com>, Radim Krcmar <rkrcmar@...hat.com>
Cc:     LKML <linux-kernel@...r.kernel.org>, kvm <kvm@...r.kernel.org>,
        Vitaly Kuznetsov <vkuznets@...hat.com>
Subject: Re: [PATCH v3 5/6] KVM: X86: Add NMI support to PV IPIs

On 20/07/2018 05:53, Wanpeng Li wrote:
>>> -     ret = kvm_hypercall3(KVM_HC_SEND_IPI, ipi_bitmap_low, ipi_bitmap_high, vector);
>>> +     switch (vector) {
>>> +     default:
>>> +             icr = APIC_DM_FIXED | vector;
>>> +             break;
>>> +     case NMI_VECTOR:
>>> +             icr = APIC_DM_NMI;
>> I think it would be better to say that KVM interprets NMI_VECTOR and
>> sends the interrupt as APIC_DM_NMI.

It's not KVM, this is arch/x86/kernel/kvm.c so the guest side.

Paolo

> Yeah, in addition, SDM 10.6.1 also mentioned that:
> Delivery mode:
>     100 (NMI) Delivers an NMI interrupt to the target processor or
> processors. The vector information is ignored.