linux-kernel - Re: [PATCH] rapidio: remove redundant pointer md

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <801e392b-c5ba-2857-c0af-157c65171bfe@gmail.com>
Date:   Thu, 19 Jul 2018 20:25:12 -0400
From:   Alexandre Bounine <alex.bou9@...il.com>
To:     Colin King <colin.king@...onical.com>,
        Matt Porter <mporter@...nel.crashing.org>,
        linux-kernel@...r.kernel.org,
        Andrew Morton <akpm@...ux-foundation.org>
Cc:     kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] rapidio: remove redundant pointer md

Acked-by: Alexandre Bounine <alex.bou9@...il.com>


On 2018-07-11 04:23 AM, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> Pointer md is being assigned but is never used hence it is redundant
> and can be removed.
> 
> Cleans up clang warning:
> warning: variable 'md' set but not used [-Wunused-but-set-variable]
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>   drivers/rapidio/devices/rio_mport_cdev.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/rapidio/devices/rio_mport_cdev.c b/drivers/rapidio/devices/rio_mport_cdev.c
> index a8cb8d2f2abb..cbe467ff1aba 100644
> --- a/drivers/rapidio/devices/rio_mport_cdev.c
> +++ b/drivers/rapidio/devices/rio_mport_cdev.c
> @@ -1006,7 +1006,6 @@ static int rio_mport_transfer_ioctl(struct file *filp, void __user *arg)
>   static int rio_mport_wait_for_async_dma(struct file *filp, void __user *arg)
>   {
>   	struct mport_cdev_priv *priv;
> -	struct mport_dev *md;
>   	struct rio_async_tx_wait w_param;
>   	struct mport_dma_req *req;
>   	dma_cookie_t cookie;
> @@ -1016,7 +1015,6 @@ static int rio_mport_wait_for_async_dma(struct file *filp, void __user *arg)
>   	int ret;
>   
>   	priv = (struct mport_cdev_priv *)filp->private_data;
> -	md = priv->md;
>   
>   	if (unlikely(copy_from_user(&w_param, arg, sizeof(w_param))))
>   		return -EFAULT;
>