linux-kernel - Re: [PATCH 2/6] drivers/md/raid5: Do not disable irq on release_inactive_stripe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180720082925.w5wncrkcaehniccm@linutronix.de>
Date:   Fri, 20 Jul 2018 10:29:25 +0200
From:   Sebastian Andrzej Siewior <bigeasy@...utronix.de>
To:     Shaohua Li <shli@...nel.org>
Cc:     linux-kernel@...r.kernel.org, tglx@...utronix.de,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...nel.org>,
        Anna-Maria Gleixner <anna-maria@...utronix.de>,
        linux-raid@...r.kernel.org
Subject: Re: [PATCH 2/6] drivers/md/raid5: Do not disable irq on
 release_inactive_stripe_list() call

On 2018-07-03 22:01:37 [+0200], To linux-kernel@...r.kernel.org wrote:
> From: Anna-Maria Gleixner <anna-maria@...utronix.de>
> 
> There is no need to invoke release_inactive_stripe_list() with interrupts
> disabled. All call sites, except raid5_release_stripe(), unlock
> ->device_lock and enable interrupts before invoking the function.
> 
> Make it consistent.

Shaohua, I've seen that you already applied 1/6. Could you also please
apply this one? This is the only remaining raid5 patch :)

> Cc: Shaohua Li <shli@...nel.org>
> Cc: linux-raid@...r.kernel.org
> Acked-by: Peter Zijlstra (Intel) <peterz@...radead.org>
> Signed-off-by: Anna-Maria Gleixner <anna-maria@...utronix.de>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
> ---
>  drivers/md/raid5.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c
> index e933bff9459e..ca1dd0cb04c5 100644
> --- a/drivers/md/raid5.c
> +++ b/drivers/md/raid5.c
> @@ -414,9 +414,8 @@ void raid5_release_stripe(struct stripe_head *sh)
>  		INIT_LIST_HEAD(&list);
>  		hash = sh->hash_lock_index;
>  		do_release_stripe(conf, sh, &list);
> -		spin_unlock(&conf->device_lock);
> +		spin_unlock_irqrestore(&conf->device_lock, flags);
>  		release_inactive_stripe_list(conf, &list, hash);
> -		local_irq_restore(flags);
>  	}
>  }
>  

Sebastian