linux-kernel - Re: [v3] Coccinelle: suggest replacing strncpy+truncation by strscpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6c657df2-a524-df22-eceb-6237cb5a9faa@users.sourceforge.net>
Date:   Fri, 20 Jul 2018 11:40:30 +0200
From:   SF Markus Elfring <elfring@...rs.sourceforge.net>
To:     Dominique Martinet <asmadeus@...ewreck.org>,
        kernel-janitors@...r.kernel.org
Cc:     cocci@...teme.lip6.fr, linux-kernel@...r.kernel.org,
        Gilles Muller <Gilles.Muller@...6.fr>,
        Julia Lawall <julia.lawall@...6.fr>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Michal Marek <michal.lkml@...kovi.net>,
        Nicolas Palix <nicolas.palix@...g.fr>,
        Ville Syrjälä <ville.syrjala@...ux.intel.com>
Subject: Re: [v3] Coccinelle: suggest replacing strncpy+truncation by strscpy

> I didn't move all virtuals in a single line because none of the other
> kernel patch do it,

It can be occasionally useful to preserve another bit of coding tradition.
I dared to propose the reconsideration of such an implementation detail.

> and still do not see any advantage of moving the string to not use a variable
> so kept that as well.

I am curious if other software developers (besides me) would like to achieve
more source code reduction according to the principle “Don't repeat yourself”.

> This should hopefully be the last version :)

* Do any related development concerns need further safety checks for this
  evolving source code transformation pattern?

* Julia Lawall has presented additional development ideas today.
  https://lore.kernel.org/lkml/alpine.DEB.2.20.1807200759230.2349@hadrien/
  https://lkml.org/lkml/2018/7/20/71

Regards,
Markus