linux-kernel - Re: linux-next: manual merge of the pci tree with Linus' tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180720124915.47ead719@windsurf>
Date:   Fri, 20 Jul 2018 12:49:15 +0200
From:   Thomas Petazzoni <thomas.petazzoni@...tlin.com>
To:     Lorenzo Pieralisi <lorenzo.pieralisi@....com>
Cc:     Stephen Rothwell <sfr@...b.auug.org.au>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Linux-Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
        Evan Wang <xswang@...vell.com>
Subject: Re: linux-next: manual merge of the pci tree with Linus' tree

Hello,

On Fri, 20 Jul 2018 10:15:53 +0100, Lorenzo Pieralisi wrote:

> >   		switch (resource_type(res)) {
> >   		case IORESOURCE_IO:
> > - 			advk_pcie_set_ob_win(pcie, 1,
> > - 					     upper_32_bits(res->start),
> > - 					     lower_32_bits(res->start),
> > - 					     0,	0xF8000000, 0,
> > - 					     lower_32_bits(res->start),
> > - 					     OB_PCIE_IO);
> >  -			err = pci_remap_iospace(res, iobase);
> >  +			err = devm_pci_remap_iospace(dev, res, iobase);
> >   			if (err) {
> >   				dev_warn(dev, "error %d: failed to map resource %pR\n",
> >   					 err, res);  
> 
> Hi Stephen,
> 
> thanks for fixing this up, the fix looks fine to me (Thomas please
> confirm), if it is I would ask Bjorn please to send it upstream when the
> time for the PCI pull request comes.

I confirm that the fix looks good to me. Thanks Stephen for fixing it
up.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com