linux-kernel - Re: [PATCH 2/2] ASoC: tegra: probe deferral error reporting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1532089865.19673.13.camel@toradex.com>
Date:   Fri, 20 Jul 2018 12:31:07 +0000
From:   Marcel Ziswiler <marcel.ziswiler@...adex.com>
To:     "broonie@...nel.org" <broonie@...nel.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "jonathanh@...dia.com" <jonathanh@...dia.com>,
        "thierry.reding@...il.com" <thierry.reding@...il.com>,
        "tiwai@...e.com" <tiwai@...e.com>,
        "lgirdwood@...il.com" <lgirdwood@...il.com>,
        "perex@...ex.cz" <perex@...ex.cz>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
        "linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>
Subject: Re: [PATCH 2/2] ASoC: tegra: probe deferral error reporting

On Fri, 2018-07-20 at 13:16 +0100, Mark Brown wrote:
> On Fri, Jul 20, 2018 at 10:04:24AM +0200, Marcel Ziswiler wrote:
> 
> > -			dev_err(&pdev->dev, "could not get codec-
> > reset GPIO\n");
> > +			dev_err(&pdev->dev, "could not get codec-
> > reset GPIO: "
> > +					    "%d\n", ret);
> 
> Don't split strings over lines like this, it causes problems when
> people
> grep for errors.  It's better to go over 80 columns.

OK, will do. However, in this case I did not actually split anything
searchable anyway.

> >  	ac97->sync_gpio = of_get_named_gpio(pdev->dev.of_node,
> >  					    "nvidia,codec-sync-
> > gpio", 0);
> >  	if (!gpio_is_valid(ac97->sync_gpio)) {
> > -		dev_err(&pdev->dev, "no codec-sync GPIO
> > supplied\n");
> > +		ret = ac97->sync_gpio;
> > +		dev_err(&pdev->dev, "no codec-sync GPIO supplied:
> > %d\n", ret);
> >  		goto err_clk_put;
> >  	}
> 
> This isn't reporting an error code associated with the attempt to
> find a
> codec-sync GPIO, it's the result of some other operation.

What exactly is then the of_get_named_gpio() above please doing if
not getting the codec sync GPIO? I am not following you, sorry.