[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20180720132258.GD18740@imbe.wolfsonmicro.main>
Date: Fri, 20 Jul 2018 14:22:58 +0100
From: Charles Keepax <ckeepax@...nsource.cirrus.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
CC: Marcel Ziswiler <marcel@...wiler.com>,
<alsa-devel@...a-project.org>, <linux-tegra@...r.kernel.org>,
Mark Brown <broonie@...nel.org>,
"Marcel Ziswiler" <marcel.ziswiler@...adex.com>,
<linux-mips@...ux-mips.org>,
Gregory CLEMENT <gregory.clement@...tlin.com>,
Haojian Zhuang <haojian.zhuang@...il.com>,
James Hogan <jhogan@...nel.org>,
"Philippe Ombredanne" <pombredanne@...b.com>,
Bhumika Goyal <bhumirks@...il.com>,
Kate Stewart <kstewart@...uxfoundation.org>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Ralf Baechle <ralf@...ux-mips.org>,
"Thierry Reding" <thierry.reding@...il.com>,
Jonathan Hunter <jonathanh@...dia.com>,
Takashi Iwai <tiwai@...e.com>,
Paul Burton <paul.burton@...s.com>,
"Liam Girdwood" <lgirdwood@...il.com>,
Lee Jones <lee.jones@...aro.org>,
"Daniel Mack" <daniel@...que.org>,
Manuel Lauss <manuel.lauss@...il.com>,
Russell King <linux@...linux.org.uk>,
<linux-arm-kernel@...ts.infradead.org>,
"Jaroslav Kysela" <perex@...ex.cz>,
Robert Jarzmik <robert.jarzmik@...e.fr>,
<patches@...nsource.cirrus.com>, <linux-kernel@...r.kernel.org>,
Han Xu <han.xu@....com>, Donglin Peng <dolinux.peng@...il.com>,
Neil Armstrong <narmstrong@...libre.com>,
Boris Brezillon <boris.brezillon@...tlin.com>
Subject: Re: [PATCH] ASoC: wm9712: fix replace codec to component
On Fri, Jul 20, 2018 at 08:30:41AM +0000, Kuninori Morimoto wrote:
>
> Hi Marcel
>
> > From: Marcel Ziswiler <marcel.ziswiler@...adex.com>
> >
> > Since commit 143b44845d87 ("ASoC: wm9712: replace codec to component")
> > "wm9712-codec" got renamed to "wm9712-component", however, this change
> > never got propagated down to the actual board/platform drivers. E.g. on
> > Colibri T20 this lead to the following spew upon boot with sound/touch
> > being broken:
>
> Oops, my bad...
> The platform_driver name is not important,
> how about simply rename back it to "wm9712-codec" ?
>
Yeah I would agree here wm9712-component isn't great as a name
for board files etc. Lets rename back to wm9712-codec for these
specific bits.
Thanks,
Charles
Powered by blists - more mailing lists