linux-kernel - Re: [PATCH] of: overlay: update phandle cache on overlay apply and remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180720150650.GA32296@rob-hp-laptop>
Date:   Fri, 20 Jul 2018 09:06:50 -0600
From:   Rob Herring <robh@...nel.org>
To:     frowand.list@...il.com
Cc:     Alan Tull <atull@...nel.org>, pantelis.antoniou@...sulko.com,
        Pantelis Antoniou <panto@...oniou-consulting.com>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        geert@...ux-m68k.org
Subject: Re: [PATCH] of: overlay: update phandle cache on overlay apply and
 remove

On Thu, Jul 12, 2018 at 02:00:07PM -0700, frowand.list@...il.com wrote:
> From: Frank Rowand <frank.rowand@...y.com>
> 
> A comment in the review of the patch adding the phandle cache said that
> the cache would have to be updated when modules are applied and removed.
> This patch implements the cache updates.
> 
> Fixes: 0b3ce78e90fc ("of: cache phandle nodes to reduce cost of of_find_node_by_phandle()")
> Reported-by: Alan Tull <atull@...nel.org>
> Suggested-by: Alan Tull <atull@...nel.org>
> Signed-off-by: Frank Rowand <frank.rowand@...y.com>
> ---
> 
> Changes since RFC:
>   - update code comment to mention race condition avoidance
> 
> For the RFC version of this patch, the 0day test reported a general
> protection fault from the KASAN runtime memory debugger on x86_64
> in qemu.  The GPF was in a devicetree unittest.
> 
> 0day tested the patch on v4.17-rc1, with some other patches applied.
> I was unable to replicate the GPF on v4.18-rc1 with just this patch
> applied.  I was also unable to replicate the GPF on a clone of the
> v4.17-rc1 0day repository, using the 0day kernel config.  I will
> reply to this email with the 0day GPF report.

Didn't see any 0-day issues, so I've applied and it is in Linus' tree 
now.

Rob