linux-kernel - Re: [PATCH] serial: 8250_ingenic: Add support for the JZ4725B SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180720153027.GA11978@rob-hp-laptop>
Date:   Fri, 20 Jul 2018 09:30:27 -0600
From:   Rob Herring <robh@...nel.org>
To:     Paul Cercueil <paul@...pouillou.net>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Mark Rutland <mark.rutland@....com>,
        Jiri Slaby <jslaby@...e.com>, linux-serial@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] serial: 8250_ingenic: Add support for the JZ4725B SoC

On Fri, Jul 13, 2018 at 04:38:40PM +0200, Paul Cercueil wrote:
> The UART in the jz4725b works just like in the other JZ SoCs, so this
> commit simply adds a new compatible string.
> 
> Signed-off-by: Paul Cercueil <paul@...pouillou.net>
> ---
>  Documentation/devicetree/bindings/serial/ingenic,uart.txt | 1 +
>  drivers/tty/serial/8250/8250_ingenic.c                    | 5 +++++
>  2 files changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/serial/ingenic,uart.txt b/Documentation/devicetree/bindings/serial/ingenic,uart.txt
> index c3c6406d5cfe..a0b34fd3b602 100644
> --- a/Documentation/devicetree/bindings/serial/ingenic,uart.txt
> +++ b/Documentation/devicetree/bindings/serial/ingenic,uart.txt
> @@ -3,6 +3,7 @@
>  Required properties:
>  - compatible : One of:
>    - "ingenic,jz4740-uart",
> +  - "ingenic,jz4725b-uart",
>    - "ingenic,jz4760-uart",
>    - "ingenic,jz4770-uart",
>    - "ingenic,jz4775-uart",
> diff --git a/drivers/tty/serial/8250/8250_ingenic.c b/drivers/tty/serial/8250/8250_ingenic.c
> index 15a8c8dfa92b..760266559a5a 100644
> --- a/drivers/tty/serial/8250/8250_ingenic.c
> +++ b/drivers/tty/serial/8250/8250_ingenic.c
> @@ -133,6 +133,10 @@ EARLYCON_DECLARE(jz4740_uart, ingenic_early_console_setup);
>  OF_EARLYCON_DECLARE(jz4740_uart, "ingenic,jz4740-uart",
>  		    ingenic_early_console_setup);
>  
> +EARLYCON_DECLARE(jz4725b_uart, ingenic_early_console_setup);
> +OF_EARLYCON_DECLARE(jz4725b_uart, "ingenic,jz4725b-uart",
> +		    ingenic_early_console_setup);
> +

This shouldn't be necessary. Looks like it should be compatible with 
ingenic,jz4740-uart.

>  EARLYCON_DECLARE(jz4770_uart, ingenic_early_console_setup);
>  OF_EARLYCON_DECLARE(jz4770_uart, "ingenic,jz4770-uart",
>  		    ingenic_early_console_setup);
> @@ -330,6 +334,7 @@ static const struct ingenic_uart_config jz4780_uart_config = {
>  
>  static const struct of_device_id of_match[] = {
>  	{ .compatible = "ingenic,jz4740-uart", .data = &jz4740_uart_config },
> +	{ .compatible = "ingenic,jz4725b-uart", .data = &jz4740_uart_config },

And this too.

>  	{ .compatible = "ingenic,jz4760-uart", .data = &jz4760_uart_config },
>  	{ .compatible = "ingenic,jz4770-uart", .data = &jz4760_uart_config },
>  	{ .compatible = "ingenic,jz4775-uart", .data = &jz4760_uart_config },
> -- 
> 2.11.0
>