[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20180720152150.GB16221@gate.crashing.org>
Date: Fri, 20 Jul 2018 10:21:50 -0500
From: Segher Boessenkool <segher@...nel.crashing.org>
To: Joe Perches <joe@...ches.com>
Cc: Dirk Gouders <dirk@...ders.net>,
Andy Whitcroft <apw@...onical.com>,
Masahiro Yamada <yamada.masahiro@...ionext.com>,
linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] checkpatch: kbuild: if_changed: check for multiple calls in targets
On Fri, Jul 20, 2018 at 03:06:37AM -0700, Joe Perches wrote:
> On Fri, 2018-07-20 at 09:48 +0200, Dirk Gouders wrote:
> > + # Check for multiple calls of if_changed within a target in Makefiles
> > + if (($realfile =~ /Makefile.*/ || $realfile =~ /Kbuild.*/) &&
>
> The uses of .* here are superfluous.
And it looks like you wanted to match this only at the beginning of the
string, which would be /^Makefile/ etc.
Segher
Powered by blists - more mailing lists