linux-kernel - Re: [PATCH net-next] xen-netfront: fix queue name setting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <566f2c29-a7c0-efee-444c-c51a632bfeee@citrix.com>
Date:   Fri, 20 Jul 2018 17:49:00 +0100
From:   Ross Lagerwall <ross.lagerwall@...rix.com>
To:     Vitaly Kuznetsov <vkuznets@...hat.com>, <netdev@...r.kernel.org>
CC:     <xen-devel@...ts.xenproject.org>, <linux-kernel@...r.kernel.org>,
        Boris Ostrovsky <boris.ostrovsky@...cle.com>,
        Juergen Gross <jgross@...e.com>
Subject: Re: [PATCH net-next] xen-netfront: fix queue name setting

On 07/20/2018 05:33 PM, Vitaly Kuznetsov wrote:
> Commit f599c64fdf7d ("xen-netfront: Fix race between device setup and
> open") changed the initialization order: xennet_create_queues() now
> happens before we do register_netdev() so using netdev->name in
> xennet_init_queue() is incorrect, we end up with the following in
> /proc/interrupts:
> 
>   60:        139          0   xen-dyn    -event     eth%d-q0-tx
>   61:        265          0   xen-dyn    -event     eth%d-q0-rx
>   62:        234          0   xen-dyn    -event     eth%d-q1-tx
>   63:          1          0   xen-dyn    -event     eth%d-q1-rx
> 
> and this looks ugly. Actually, using early netdev name (even when it's
> already set) is also not ideal: nowadays we tend to rename eth devices
> and queue name may end up not corresponding to the netdev name.
> 
> Use nodename from xenbus device for queue naming: this can't change in VM's
> lifetime. Now /proc/interrupts looks like
> 
>   62:        202          0   xen-dyn    -event     device/vif/0-q0-tx
>   63:        317          0   xen-dyn    -event     device/vif/0-q0-rx
>   64:        262          0   xen-dyn    -event     device/vif/0-q1-tx
>   65:         17          0   xen-dyn    -event     device/vif/0-q1-rx
> 
> Fixes: f599c64fdf7d ("xen-netfront: Fix race between device setup and open")
> Signed-off-by: Vitaly Kuznetsov <vkuznets@...hat.com>
> ---

Reviewed-by: Ross Lagerwall <ross.lagerwall@...rix.com>