linux-kernel - Re: [PATCH v2 bpf-next] bpfilter: Fix mismatch in function argument types

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180721.162151.2056706808480433302.davem@davemloft.net>
Date:   Sat, 21 Jul 2018 16:21:51 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     daniel@...earbox.net
Cc:     kafai@...com, yuehaibing@...wei.com, ast@...nel.org,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH v2 bpf-next] bpfilter: Fix mismatch in function
 argument types

From: Daniel Borkmann <daniel@...earbox.net>
Date: Thu, 19 Jul 2018 17:51:41 +0200

> On 07/19/2018 05:48 PM, Martin KaFai Lau wrote:
>> On Thu, Jul 19, 2018 at 03:56:59PM +0800, YueHaibing wrote:
>>> Fix following warning:
>>> net/ipv4/bpfilter/sockopt.c:28:5: error: symbol 'bpfilter_ip_set_sockopt' redeclared with different type
>>> net/ipv4/bpfilter/sockopt.c:34:5: error: symbol 'bpfilter_ip_get_sockopt' redeclared with different type
>>>
>>> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
>> LGTM.  Missing a Fixes tag though.
>> 
>> Fixes: d2ba09c17a06 ("net: add skeleton of bpfilter kernel module")
>> Acked-by: Martin KaFai Lau <kafai@...com>
> 
> (Should go to -net tree.)
> 
> Acked-by: Daniel Borkmann <daniel@...earbox.net>

Applied.