linux-kernel - Re: [PATCH v2 1/3] vt: avoid a VLA in the unicode screen scroll function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 21 Jul 2018 09:20:43 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Nicolas Pitre <nicolas.pitre@...aro.org>
Cc:     Adam Borowski <kilobyte@...band.pl>,
        Kees Cook <keescook@...omium.org>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Dave Mielke <Dave@...lke.cc>,
        Samuel Thibault <samuel.thibault@...-lyon.org>,
        linux-kernel@...r.kernel.org, linux-console@...r.kernel.org
Subject: Re: [PATCH v2 1/3] vt: avoid a VLA in the unicode screen scroll
 function

On Thu, Jul 19, 2018 at 12:05:25AM -0400, Nicolas Pitre wrote:
> 
> The nr argument is typically small: most often nr == 1. However this
> could be abused with a very large explicit scroll in a resized screen.
> Make the code scroll lines by performing an array rotation operation to
> avoid the need for a large temporary space.
> 
> Requested-by: Kees Cook <keescook@...omium.org>
> Suggested-by: Adam Borowski <kilobyte@...band.pl>
> Signed-off-by: Nicolas Pitre <nico@...aro.org>

I've now applied this v2 of the patch, thanks for this.

greg k-h