linux-kernel - Re: [PATCH 2/3] tty: Make constants to be enums instead of #define in goldfish.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180721074521.GB6484@kroah.com>
Date:   Sat, 21 Jul 2018 09:45:21 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     rkir@...gle.com
Cc:     linux-kernel@...r.kernel.org, tkjos@...gle.com
Subject: Re: [PATCH 2/3] tty: Make constants to be enums instead of #define
 in goldfish.c

On Tue, Jul 17, 2018 at 05:14:54PM -0700, rkir@...gle.com wrote:
> From: Roman Kiryanov <rkir@...gle.com>
> 
> enums produce better compilation errors than defines.

Yes, if you name the enum.  But you didn't do that here, so this patch
really does not do anything to cause any "protection" at all :(

Please fix this up and resend.

thanks,

greg k-h