linux-kernel - Re: [PATCH] arch/h8300: eliminate kgbd.c warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 22 Jul 2018 22:33:35 +0900
From:   Yoshinori Sato <ysato@...rs.sourceforge.jp>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        uclinux-h8-devel@...ts.sourceforge.jp
Subject: Re: [PATCH] arch/h8300: eliminate kgbd.c warning

On Fri, 20 Jul 2018 11:36:06 +0900,
Randy Dunlap wrote:
> 
> From: Randy Dunlap <rdunlap@...radead.org>
> 
> Drop the "const" qualifier from arch_kgdb_ops to eliminate the gcc
> warning (gcc version is 8.1.0).
> 
> arch/h8300/kernel/kgdb.c:132:24: error: conflicting type qualifiers for 'arch_kgdb_ops'
>  const struct kgdb_arch arch_kgdb_ops = {
> In file included from ../arch/h8300/kernel/kgdb.c:12:
> ../include/linux/kgdb.h:284:26: note: previous declaration of 'arch_kgdb_ops' was here
>  extern struct kgdb_arch  arch_kgdb_ops;
> 
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Yoshinori Sato <ysato@...rs.sourceforge.jp>
> Cc: uclinux-h8-devel@...ts.sourceforge.jp
> ---
>  arch/h8300/kernel/kgdb.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- linux-next-20180717.orig/arch/h8300/kernel/kgdb.c
> +++ linux-next-20180717/arch/h8300/kernel/kgdb.c
> @@ -129,7 +129,7 @@ void kgdb_arch_exit(void)
>  	/* Nothing to do */
>  }
>  
> -const struct kgdb_arch arch_kgdb_ops = {
> +struct kgdb_arch arch_kgdb_ops = {
>  	/* Breakpoint instruction: trapa #2 */
>  	.gdb_bpt_instr = { 0x57, 0x20 },
>  };
> 
> 

Applied to h8300-next.
Thanks.

-- 
Yosinori Sato