linux-kernel - Re: [PATCH 1/9] h8300: Don't include linux/kernel.h in asm/atomic.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87in57fk40.wl-ysato@users.sourceforge.jp>
Date:   Sun, 22 Jul 2018 22:58:07 +0900
From:   Yoshinori Sato <ysato@...rs.sourceforge.jp>
To:     Will Deacon <will.deacon@....com>
Cc:     linux-kernel@...r.kernel.org, peterz@...radead.org,
        mingo@...nel.org, linux-arm-kernel@...ts.infradead.org,
        yamada.masahiro@...ionext.com
Subject: Re: [PATCH 1/9] h8300: Don't include linux/kernel.h in asm/atomic.h

On Thu, 24 May 2018 19:59:38 +0900,
Will Deacon wrote:
> 
> linux/kernel.h isn't needed by asm/atomic.h and will result in circular
> dependencies when the asm-generic atomic bitops are built around the
> tomic_long_t interface.
> 
> Remove the broad include and replace it with linux/compiler.h for
> READ_ONCE etc and asm/irqflags.h for arch_local_irq_save etc.
> 
> Cc: Yoshinori Sato <ysato@...rs.sourceforge.jp>
> Signed-off-by: Will Deacon <will.deacon@....com>
> ---
>  arch/h8300/include/asm/atomic.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/h8300/include/asm/atomic.h b/arch/h8300/include/asm/atomic.h
> index 941e7554e886..b174dec099bf 100644
> --- a/arch/h8300/include/asm/atomic.h
> +++ b/arch/h8300/include/asm/atomic.h
> @@ -2,8 +2,10 @@
>  #ifndef __ARCH_H8300_ATOMIC__
>  #define __ARCH_H8300_ATOMIC__
>  
> +#include <linux/compiler.h>
>  #include <linux/types.h>
>  #include <asm/cmpxchg.h>
> +#include <asm/irqflags.h>
>  
>  /*
>   * Atomic operations that C can't guarantee us.  Useful for
> @@ -15,8 +17,6 @@
>  #define atomic_read(v)		READ_ONCE((v)->counter)
>  #define atomic_set(v, i)	WRITE_ONCE(((v)->counter), (i))
>  
> -#include <linux/kernel.h>
> -
>  #define ATOMIC_OP_RETURN(op, c_op)				\
>  static inline int atomic_##op##_return(int i, atomic_t *v)	\
>  {								\
> -- 
> 2.1.4
> 

Sorry too late reply.
Applied to h8300-next.
Thanks.

-- 
Yosinori Sato