linux-kernel - [tip:efi/core] efi/cper: Use consistent types for UUIDs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <tip-e8f4194d9b98aa13f9f567a0056bbf683d2b1ab8@git.kernel.org>
Date:   Sun, 22 Jul 2018 08:23:13 -0700
From:   tip-bot for Andy Shevchenko <tipbot@...or.com>
To:     linux-tip-commits@...r.kernel.org
Cc:     peterz@...radead.org, andriy.shevchenko@...ux.intel.com,
        tbaicar@...eaurora.org, hdegoede@...hat.com,
        linux-kernel@...r.kernel.org, ard.biesheuvel@...aro.org,
        hpa@...or.com, lukas@...ner.de, torvalds@...ux-foundation.org,
        tglx@...utronix.de, mingo@...nel.org
Subject: [tip:efi/core] efi/cper: Use consistent types for UUIDs

Commit-ID:  e8f4194d9b98aa13f9f567a0056bbf683d2b1ab8
Gitweb:     https://git.kernel.org/tip/e8f4194d9b98aa13f9f567a0056bbf683d2b1ab8
Author:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
AuthorDate: Fri, 20 Jul 2018 10:47:25 +0900
Committer:  Ingo Molnar <mingo@...nel.org>
CommitDate: Sun, 22 Jul 2018 14:13:43 +0200

efi/cper: Use consistent types for UUIDs

The commit:

  2f74f09bce4f ("efi: parse ARM processor error")

... brought inconsistency in UUID types which are used across the CPER.

Fix this by moving to use guid_t API everywhere.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@...aro.org>
Cc: Hans de Goede <hdegoede@...hat.com>
Cc: Linus Torvalds <torvalds@...ux-foundation.org>
Cc: Lukas Wunner <lukas@...ner.de>
Cc: Peter Zijlstra <peterz@...radead.org>
Cc: Thomas Gleixner <tglx@...utronix.de>
Cc: Tyler Baicar <tbaicar@...eaurora.org>
Cc: linux-efi@...r.kernel.org
Link: http://lkml.kernel.org/r/20180720014726.24031-9-ard.biesheuvel@linaro.org
Signed-off-by: Ingo Molnar <mingo@...nel.org>
---
 drivers/firmware/efi/cper.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/firmware/efi/cper.c b/drivers/firmware/efi/cper.c
index b73fc4cab083..a7902fccdcfa 100644
--- a/drivers/firmware/efi/cper.c
+++ b/drivers/firmware/efi/cper.c
@@ -472,7 +472,7 @@ cper_estatus_print_section(const char *pfx, struct acpi_hest_generic_data *gdata
 		else
 			goto err_section_too_small;
 #if defined(CONFIG_ARM64) || defined(CONFIG_ARM)
-	} else if (!uuid_le_cmp(*sec_type, CPER_SEC_PROC_ARM)) {
+	} else if (guid_equal(sec_type, &CPER_SEC_PROC_ARM)) {
 		struct cper_sec_proc_arm *arm_err = acpi_hest_get_payload(gdata);
 
 		printk("%ssection_type: ARM processor error\n", newpfx);