linux-kernel - Re: [PATCH 2/2] power: supply: lego_ev3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180722220235.3cjpvsufswcqu53g@earth.universe>
Date:   Mon, 23 Jul 2018 00:02:35 +0200
From:   Sebastian Reichel <sebastian.reichel@...labora.co.uk>
To:     David Lechner <david@...hnology.com>
Cc:     linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] power: supply: lego_ev3_battery: fix Vce offset

Hi,

On Fri, Jul 20, 2018 at 03:19:44PM -0500, David Lechner wrote:
> This fixes the value that accounts for the Vce of a transistor in the
> LEGO MINDSTORMS EV3 power supply driver. The old value (200mV) was the
> max value from the data sheet. After testing, the actual value has been
> found to be 50mV. By using 50mV we get a more accurate voltage
> indication.
> 
> Signed-off-by: David Lechner <david@...hnology.com>
> ---

Thanks, queued to power-supply's for-next branch.

-- Sebastian

>  drivers/power/supply/lego_ev3_battery.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/power/supply/lego_ev3_battery.c b/drivers/power/supply/lego_ev3_battery.c
> index 6e3b3e384172..1ae3710909b7 100644
> --- a/drivers/power/supply/lego_ev3_battery.c
> +++ b/drivers/power/supply/lego_ev3_battery.c
> @@ -52,7 +52,7 @@ static int lego_ev3_battery_get_property(struct power_supply *psy,
>  			return ret;
>  
>  		val->intval *= 2000;
> -		val->intval += 200000;
> +		val->intval += 50000;
>  
>  		/* plus adjust for shunt resistor drop */
>  		ret = iio_read_channel_processed(batt->iio_i, &val2);
> -- 
> 2.17.1
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)