linux-kernel - Re: [PATCH] arch/h8300: fix kernel/dma.c build warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 22 Jul 2018 11:25:59 +0200
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     Richard Kuo <rkuo@...eaurora.org>,
        "open list:QUALCOMM HEXAGON..." <linux-hexagon@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Yoshinori Sato <ysato@...rs.sourceforge.jp>,
        Rich Felker <dalias@...c.org>,
        Linux-sh list <linux-sh@...r.kernel.org>
Subject: Re: [PATCH] arch/h8300: fix kernel/dma.c build warning

CC hexagon

hexagon != H8/300 != SuperH

On Sat, Jul 21, 2018 at 5:17 AM Randy Dunlap <rdunlap@...radead.org> wrote:
>
> From: Randy Dunlap <rdunlap@...radead.org>
>
> Fix build warning in arch/hexagon/kernel/dma.c by casting a void *
> to unsigned long to match the function parameter type.
>
> ../arch/hexagon/kernel/dma.c: In function 'arch_dma_alloc':
> ../arch/hexagon/kernel/dma.c:51:5: warning: passing argument 2 of 'gen_pool_add' makes integer from pointer without a cast [enabled by default]
> ../include/linux/genalloc.h:112:19: note: expected 'long unsigned int' but argument is of type 'void *'
>
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Yoshinori Sato <ysato@...rs.sourceforge.jp>
> Cc: Rich Felker <dalias@...c.org>
> Cc: linux-sh@...r.kernel.org
> ---
>  arch/hexagon/kernel/dma.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-next-20180717.orig/arch/hexagon/kernel/dma.c
> +++ linux-next-20180717/arch/hexagon/kernel/dma.c
> @@ -47,7 +47,7 @@ void *arch_dma_alloc(struct device *dev,
>                         panic("Can't create %s() memory pool!", __func__);
>                 else
>                         gen_pool_add(coherent_pool,
> -                               pfn_to_virt(max_low_pfn),
> +                               (unsigned long)pfn_to_virt(max_low_pfn),
>                                 hexagon_coherent_pool_size, -1);
>         }
>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds