linux-kernel - Re: [PATCH 05/11] touchscreen: elants: Use octal permissions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180722093958.GB13612@kroah.com>
Date:   Sun, 22 Jul 2018 11:39:58 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     dev-harsh1998 <harshitjain6751@...il.com>
Cc:     trivial@...nel.org, Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Andi Shyti <andi@...zian.org>,
        Simon Budig <simon.budig@...nelconcepts.de>,
        Luca Ceresoli <luca@...aceresoli.net>,
        Guenter Roeck <linux@...ck-us.net>,
        Joe Perches <joe@...ches.com>, linux-input@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 05/11] touchscreen: elants: Use octal permissions

On Sun, Jul 22, 2018 at 12:39:45AM +0530, dev-harsh1998 wrote:
> WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'.
> +static DEVICE_ATTR(iap_mode, S_IRUGO, show_iap_mode, NULL);
> 
> WARNING: Symbolic permissions 'S_IWUSR' are not preferred. Consider using octal permissions '0200'.
> +static DEVICE_ATTR(update_fw, S_IWUSR, NULL, write_update_fw)
> 
> WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'.
> +		.dattr = __ATTR(_field, S_IRUGO,			\
> 
> Signed-off-by: dev-harsh1998 <harshitjain6751@...il.com>

You need to use your real name when creating Linux kernel patches.

thanks,

greg k-h