linux-kernel - Re: [PATCH] NTB: fix debugfs_simple

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 23 Jul 2018 11:57:45 -0600
From:   Logan Gunthorpe <logang@...tatee.com>
To:     Julia Lawall <julia.lawall@...6.fr>
Cc:     Jon Mason <jdmason@...zu.us>, Dave Jiang <dave.jiang@...el.com>,
        Allen Hubbe <allenbh@...il.com>, linux-ntb@...glegroups.com,
        linux-kernel@...r.kernel.org, kbuild-all@...org
Subject: Re: [PATCH] NTB: fix debugfs_simple_attr.cocci warnings



On 21/07/18 12:47 AM, Julia Lawall wrote:
> From: kbuild test robot <fengguang.wu@...el.com>
> 
>  Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE
>  for debugfs files.
> 
>  Rationale: DEFINE_SIMPLE_ATTRIBUTE + debugfs_create_file()
>  imposes some significant overhead as compared to
>  DEFINE_DEBUGFS_ATTRIBUTE + debugfs_create_file_unsafe().
> 
> Generated by: scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci
> 
> Fixes: c75153197d20 ("NTB: Introduce NTB MSI Test Client")
> Signed-off-by: kbuild test robot <fengguang.wu@...el.com>
> Signed-off-by: Julia Lawall <julia.lawall@...6.fr>
> ---
> 
> I don't know much about this issue, beyondwhat is explained by the
> semantic patch.  Please check if the changes can be relevant.

Oops, this work wasn't meant for public consumption yet. Everyone
pretend you didn't see that ;). I must have pushed it to my repo that
kbuild tests by accident.

Though, I'm glad to have learned about the more efficient use of debugfs
attributes.

Logan