linux-kernel - [PATCH 01/15] staging:rtl8192u: Remove typedef of u32 to QOS_MODE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 23 Jul 2018 21:50:17 +0100
From:   John Whitmore <johnfwhitmore@...il.com>
To:     linux-kernel@...r.kernel.org
Cc:     devel@...verdev.osuosl.org, gregkh@...uxfoundation.org,
        pombredanne@...b.com, kstewart@...uxfoundation.org,
        tglx@...utronix.de, John Whitmore <johnfwhitmore@...il.com>
Subject: [PATCH 01/15] staging:rtl8192u: Remove typedef of u32 to QOS_MODE - Style

The typedef of QOS_MODE as a u32 is contrary to coding standard and fails
the checkpatch tests for defining new types in code. Definitions of type
QOS_MODE have simply been replaced with a u32 type.

This is a coding style change which should not impact runtime execution.

Signed-off-by: John Whitmore <johnfwhitmore@...il.com>
---
 drivers/staging/rtl8192u/ieee80211/rtl819x_Qos.h | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_Qos.h b/drivers/staging/rtl8192u/ieee80211/rtl819x_Qos.h
index 96e9621e9887..45ba96a13b13 100644
--- a/drivers/staging/rtl8192u/ieee80211/rtl819x_Qos.h
+++ b/drivers/staging/rtl8192u/ieee80211/rtl819x_Qos.h
@@ -16,7 +16,6 @@
 //	QOS_HCCA			= 4,
 //}QOS_MODE,*PQOS_MODE;
 //
-typedef u32 QOS_MODE, *PQOS_MODE;
 #define QOS_DISABLE		0
 #define QOS_WMM			1
 #define QOS_WMMSA		2
@@ -454,8 +453,8 @@ typedef struct _STA_QOS {
 	u8				*WMMIE;
 
 	// Part 1. Self QoS Mode.
-	QOS_MODE			QosCapability; //QoS Capability, 2006-06-14 Isaiah
-	QOS_MODE			CurrentQosMode;
+	u32			        QosCapability;  // QOS_MODE QoS Capability, 2006-06-14 Isaiah
+	u32			        CurrentQosMode; // QOS_MODE
 
 	// For WMM Power Save Mode :
 	// ACs are trigger/delivery enabled or legacy power save enabled. 2006-06-13 Isaiah
@@ -502,7 +501,7 @@ typedef struct _STA_QOS {
 // Ref: BssDscr in 8185 code. [def. in BssDscr.h]
 //
 typedef struct _BSS_QOS {
-	QOS_MODE		bdQoSMode;
+	u32		        bdQoSMode;    // QOS_MODE
 
 	u8			bdWMMIEBuf[MAX_WMMELE_LENGTH];
 	u8		*bdWMMIE;
-- 
2.18.0