linux-kernel - Re: [PATCH v2] IB/mlx5: avoid excessive warning msgs when creating VFs on 2nd port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <be7536a3-3548-3e89-fad4-71180511a5ce@mellanox.com>
Date:   Mon, 23 Jul 2018 16:17:23 -0500
From:   Daniel Jurgens <danielj@...lanox.com>
To:     Qing Huang <qing.huang@...cle.com>, linux-kernel@...r.kernel.org,
        linux-rdma@...r.kernel.org
Cc:     jgg@...pe.ca, dledford@...hat.com, leon@...nel.org,
        gerald.gibson@...cle.com, sharon.s.liu@...cle.com
Subject: Re: [PATCH v2] IB/mlx5: avoid excessive warning msgs when creating
 VFs on 2nd port



On 7/23/2018 4:15 PM, Qing Huang wrote:
> When a CX5 device is configured in dual-port RoCE mode, after creating
> many VFs against port 1, creating the same number of VFs against port 2
> will flood kernel/syslog with something like
> "mlx5_*:mlx5_ib_bind_slave_port:4266:(pid 5269): port 2 already
> affiliated."
>
> So basically, when traversing mlx5_ib_dev_list, mlx5_ib_add_slave_port()
> repeatedly attempts to bind the new mpi structure to every device
> on the list until it finds an unbound device.
>
> Change the log level from warn to dbg to avoid log flooding as the warning
> should be harmless.
>
> Signed-off-by: Qing Huang <qing.huang@...cle.com>
> ---
>   v1 -> v2: change the log level instead
>
>  drivers/infiniband/hw/mlx5/main.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/infiniband/hw/mlx5/main.c b/drivers/infiniband/hw/mlx5/main.c
> index b3ba9a2..f57b8f7 100644
> --- a/drivers/infiniband/hw/mlx5/main.c
> +++ b/drivers/infiniband/hw/mlx5/main.c
> @@ -5127,8 +5127,8 @@ static bool mlx5_ib_bind_slave_port(struct mlx5_ib_dev *ibdev,
>  
>  	spin_lock(&ibdev->port[port_num].mp.mpi_lock);
>  	if (ibdev->port[port_num].mp.mpi) {
> -		mlx5_ib_warn(ibdev, "port %d already affiliated.\n",
> -			     port_num + 1);
> +		mlx5_ib_dbg(ibdev, "port %d already affiliated.\n",
> +			    port_num + 1);
>  		spin_unlock(&ibdev->port[port_num].mp.mpi_lock);
>  		return false;
>  	}
Reviewed-by: Daniel Jurgens <danielj@...lanox.com>