linux-kernel - Re: [PATCH] block: ioprio: Replace GFP_ATOMIC with GFP_KERNEL in set_task

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8dab79c6-eb75-b013-1f83-3af43a7052cb@I-love.SAKURA.ne.jp>
Date:   Tue, 24 Jul 2018 06:49:32 +0900
From:   Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>
To:     Christoph Hellwig <hch@...radead.org>,
        Jia-Ju Bai <baijiaju1990@...il.com>
Cc:     axboe@...nel.dk, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] block: ioprio: Replace GFP_ATOMIC with GFP_KERNEL in
 set_task_ioprio()

On 2018/07/23 16:18, Christoph Hellwig wrote:
> Looks good,

Looks bad. :-(

SYSCALL_DEFINE3(ioprio_set, int, which, int, who, int, ioprio)
{
(...snipped...)
	rcu_read_lock();
(...snipped...)
	ret = set_task_ioprio(p, ioprio);
(...snipped...)
	rcu_read_unlock();
(...snipped...)
}

> 
> Reviewed-by: Christoph Hellwig <hch@....de>
> 
> But to me it seems that btrfs and maybe ext4 as well would be much
> better off just setting a per-IO priority in the bio.
> 
> Any chance yo could look into that?
>