lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 23 Jul 2018 11:46:19 +0530 From: kgunda@...eaurora.org To: Pavel Machek <pavel@....cz> Cc: Daniel Thompson <daniel.thompson@...aro.org>, bjorn.andersson@...aro.org, jingoohan1@...il.com, lee.jones@...aro.org, b.zolnierkie@...sung.com, dri-devel@...ts.freedesktop.org, jacek.anaszewski@...il.com, robh+dt@...nel.org, mark.rutland@....com, linux-leds@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, linux-fbdev@...r.kernel.org, linux-arm-msm@...r.kernel.org Subject: Re: [PATCH V4 6/8] backlight: qcom-wled: Add support for WLED4 peripheral On 2018-07-21 02:51, Pavel Machek wrote: > Hi! > >> >@@ -332,6 +529,7 @@ static u32 wled_values(const struct wled_var_cfg *cfg, u32 idx) >> > } >> > #define WLED3 3 >> >+#define WLED4 4 >> >> Are these macros always going to define 3 to be 3 and 4 to be 4. If so >> we >> probably don't need them (and they should be removed from patch 5/8 >> too). >> >> There is a degree of nitpicking here however. The rest looks OK to me. > > Really nitpicking, and I don't care much either way, but as natural > numbering would be 0-based, I'd keep the defines. > Pavel Thanks Pavale/Daniel! I will remove the macros and use the number 3 and 4 instead.
Powered by blists - more mailing lists