[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAMuHMdV9yvjTkpao2SdnWObQpjeNV_g=cJwq-SCzDiXvq8jNdw@mail.gmail.com>
Date: Mon, 23 Jul 2018 09:58:33 +0200
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Randy Dunlap <rdunlap@...radead.org>
Cc: Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
Richard Kuo <rkuo@...eaurora.org>,
"open list:QUALCOMM HEXAGON..." <linux-hexagon@...r.kernel.org>
Subject: Re: [PATCH v2] hexagon: modify ffs() and fls() to return int
On Mon, Jul 23, 2018 at 1:04 AM Randy Dunlap <rdunlap@...radead.org> wrote:
> From: Randy Dunlap <rdunlap@...radead.org>
>
> Building drivers/mtd/nand/raw/nandsim.c on arch/hexagon/ produces a
> printk format build warning. This is due to hexagon's ffs() being
> coded as returning long instead of int.
>
> Fix the printk format warning by changing all of hexagon's ffs() and
> fls() functions to return int instead of long. The variables that
> they return are already int instead of long. This return type
> matches the return type in <asm-generic/bitops/>.
>
> ../drivers/mtd/nand/raw/nandsim.c: In function 'init_nandsim':
> ../drivers/mtd/nand/raw/nandsim.c:760:2: warning: format '%u' expects argument of type 'unsigned int', but argument 2 has type 'long int' [-Wformat]
>
> There are no ffs() or fls() allmodconfig build errors after making this
> change.
>
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Richard Kuo <rkuo@...eaurora.org>
> Cc: linux-hexagon@...r.kernel.org
> Cc: Geert Uytterhoeven <geert@...ux-m68k.org>
Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Powered by blists - more mailing lists