linux-kernel - RE: arch/arc/ allmodconfig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DB6PR05MB4597A63819F227B17652B5B2B2560@DB6PR05MB4597.eurprd05.prod.outlook.com>
Date:   Mon, 23 Jul 2018 08:34:42 +0000
From:   "Ofer Levi(SW)" <oferle@...lanox.com>
To:     Vineet Gupta <Vineet.Gupta1@...opsys.com>,
        Randy Dunlap <rdunlap@...radead.org>,
        LKML <linux-kernel@...r.kernel.org>,
        "linux-snps-arc@...ts.infradead.org" 
        <linux-snps-arc@...ts.infradead.org>
CC:     Leon Romanovsky <leonro@...lanox.com>,
        Meir Lichtinger <meirl@...lanox.com>
Subject: RE: arch/arc/ allmodconfig

Hi Vineet, randy

Indeed this structure is missing, following is a patch based on linux-4.17.9.
Sorry about that.

Thanks


diff -uprN linux-4.17.9.org/arch/arc/plat-eznps/include/plat/ctop.h linux-4.17.9/arch/arc/plat-eznps/include/plat/ctop.h
--- linux-4.17.9.org/arch/arc/plat-eznps/include/plat/ctop.h    2018-07-22 16:16:09.000000000 +0300
+++ linux-4.17.9/arch/arc/plat-eznps/include/plat/ctop.h        2018-07-23 11:18:12.179402620 +0300
@@ -143,6 +143,15 @@ struct nps_host_reg_gim_p_int_dst {
 };
 
 /* AUX registers definition */
+struct nps_host_reg_aux_dpc {
+       union {
+               struct {
+                       u32 ien:1, men:1, hen:1, reserved:29;
+               };
+               u32 value;
+       };
+};
+
 struct nps_host_reg_aux_udmc {
        union {
                struct {




> -----Original Message-----
> From: Meir Lichtinger
> Sent: Friday, July 20, 2018 10:19
> To: Vineet Gupta <Vineet.Gupta1@...opsys.com>; Randy Dunlap
> <rdunlap@...radead.org>; LKML <linux-kernel@...r.kernel.org>; linux-
> snps-arc@...ts.infradead.org; Ofer Levi(SW) <oferle@...lanox.com>
> Cc: Leon Romanovsky <leonro@...lanox.com>
> Subject: RE: arch/arc/ allmodconfig
> 
> Hi Vineet,
> Ofer Levi is now the maintainer of arch/arc/plat-eznps
> 
> Ofer,
> Please take care of the issue below
> 
> Thanks
> 
> 
> -----Original Message-----
> From: Vineet Gupta [mailto:Vineet.Gupta1@...opsys.com]
> Sent: Thursday, July 19, 2018 19:22
> To: Randy Dunlap <rdunlap@...radead.org>; LKML <linux-
> kernel@...r.kernel.org>; Vineet Gupta <Vineet.Gupta1@...opsys.com>;
> linux-snps-arc@...ts.infradead.org
> Cc: Elad Kanfi <eladkan@...lanox.com>; Leon Romanovsky
> <leonro@...lanox.com>
> Subject: Re: arch/arc/ allmodconfig
> 
> +CC some folks from Mellanox
> 
> On 07/18/2018 10:37 PM, Randy Dunlap wrote:
> > Hi,
> >
> > When I try to (cross-)build arch/arc/ allmodconfig, I get a syntax error here:
> >
> > ./arch/arc/plat-eznps/mtm.c: In function 'mtm_enable_core':
> > ../arch/arc/plat-eznps/mtm.c:113:30: error: storage size of 'dpc' isn't known
> >   struct nps_host_reg_aux_dpc dpc;
> >                               ^~~
> >
> > There is no struct nps_host_reg_aux_dpc in the kernel tree.
> >
> > Can you do something about this, please?
> 
> Thx for the report Randy. I'm calling out Mellanox folks to see if they can
> provide a fixup, else we will revert the corresponding change.
> 
> @Elad, upstream commit 3f9cd874dcc8705 "ARC: [plat-eznps] avoid toggling
> of DPC register" added reference to struct nps_host_reg_aux_dpc but the
> definition is missing. Can you please provide a fixup as I have no idea of that
> platform specific struct.
> 
> @ Leon, reaching our to you, since it seems you removed Elad from
> MAINTAINERS file, so I'm not sure if he is still at Mellanox.
> The two folks I worked with on EZCHiip Linux port Noam Camus and Gilad
> have left Mellanox.
> If you or someone from Mellanox are interested in maintaining this platform,
> please update the arch/arc/plat-eznps section of MAINTAINERS file.
> 
> 
> Thx,
> -Vineet