linux-kernel - Re: [PATCH v5 0/8] xen: dma-buf support for grant device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <df3e8c07-c8b4-cb12-32ad-119498be114b@epam.com>
Date:   Mon, 23 Jul 2018 11:38:59 +0300
From:   Oleksandr Andrushchenko <Oleksandr_Andrushchenko@...m.com>
To:     Boris Ostrovsky <boris.ostrovsky@...cle.com>,
        Oleksandr Andrushchenko <andr2000@...il.com>,
        xen-devel@...ts.xenproject.org, linux-kernel@...r.kernel.org,
        dri-devel@...ts.freedesktop.org, linux-media@...r.kernel.org,
        jgross@...e.com, konrad.wilk@...cle.com
Cc:     daniel.vetter@...el.com, dongwon.kim@...el.com,
        matthew.d.roper@...el.com
Subject: Re: [PATCH v5 0/8] xen: dma-buf support for grant device

On 07/20/2018 05:08 PM, Boris Ostrovsky wrote:
> On 07/20/2018 05:01 AM, Oleksandr Andrushchenko wrote:
>> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@...m.com>
>>
>> This work is in response to my previous attempt to introduce Xen/DRM
>> zero-copy driver [1] to enable Linux dma-buf API [2] for Xen based
>> frontends/backends. There is also an existing hyper_dmabuf approach
>> available [3] which, if reworked to utilize the proposed solution,
>> can greatly benefit as well.
>
> Lot of warnings on  i386 build:
>
> In file included from
> /data/upstream/linux-xen/drivers/gpu/drm/xen/xen_drm_front.c:24:
> /data/upstream/linux-xen/drivers/gpu/drm/xen/xen_drm_front.h: In
> function ‘xen_drm_front_fb_to_cookie’:
> /data/upstream/linux-xen/drivers/gpu/drm/xen/xen_drm_front.h:129:9:
> warning: cast from pointer to integer of different size
> [-Wpointer-to-int-cast]
>    return (u64)fb;
>           ^
> /data/upstream/linux-xen/drivers/gpu/drm/xen/xen_drm_front.h: In
> function ‘xen_drm_front_dbuf_to_cookie’:
> /data/upstream/linux-xen/drivers/gpu/drm/xen/xen_drm_front.h:134:9:
> warning: cast from pointer to integer of different size
> [-Wpointer-to-int-cast]
>    return (u64)gem_obj;
>           ^
>    CC [M]  net/netfilter/ipset/ip_set_hash_ipport.o
>    CC      drivers/media/rc/keymaps/rc-tango.o
>    CC [M]  drivers/gpu/drm/vmwgfx/vmwgfx_fifo.o
>    AR      drivers/misc/built-in.a
> In file included from
> /data/upstream/linux-xen/drivers/gpu/drm/xen/xen_drm_front_kms.c:20:
> /data/upstream/linux-xen/drivers/gpu/drm/xen/xen_drm_front.h: In
> function ‘xen_drm_front_fb_to_cookie’:
>    CC [M]  drivers/gpu/drm/xen/xen_drm_front_conn.o
> /data/upstream/linux-xen/drivers/gpu/drm/xen/xen_drm_front.h:129:9:
> warning: cast from pointer to integer of different size
> [-Wpointer-to-int-cast]
>    return (u64)fb;
> (and more)
>
The above warnings already have a fix [1] which is expected in 4.19
>
> and then
>
> data/upstream/linux-xen/drivers/xen/gntdev-dmabuf.c: In function
> ‘gntdev_ioctl_dmabuf_exp_from_refs’:
> /data/upstream/linux-xen/drivers/xen/gntdev-dmabuf.c:503:6: warning:
> ‘args.fd’ may be used uninitialized in this function [-Wmaybe-uninitialized]
>    *fd = args.fd;
>    ~~~~^~~~~~~~~
> /data/upstream/linux-xen/drivers/xen/gntdev-dmabuf.c:467:35: note:
> ‘args.fd’ was declared here
>    struct gntdev_dmabuf_export_args args;
>                                     ^~~~
Strangely, but my i386 build goes smooth.
Which version of gcc you use and could you please give me your
.config, so I can test the same?
>
> -boris
Thank you,
Oleksandr

[1] 
https://cgit.freedesktop.org/drm/drm-misc/commit/?id=9eece5d9c6e0316f17091e37ff3ec87331bdedf3