linux-kernel - Re: [PATCH v2] tg: show the sum wait time of an task group

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180723093121.GA2494@hirez.programming.kicks-ass.net>
Date:   Mon, 23 Jul 2018 11:31:21 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     王贇 <yun.wang@...ux.alibaba.com>
Cc:     Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] tg: show the sum wait time of an task group

On Wed, Jul 04, 2018 at 11:27:27AM +0800, 王贇 wrote:

> @@ -6788,6 +6790,12 @@ static int cpu_cfs_stat_show(struct seq_file *sf, void *v)
>  	seq_printf(sf, "nr_throttled %d\n", cfs_b->nr_throttled);
>  	seq_printf(sf, "throttled_time %llu\n", cfs_b->throttled_time);
> 
> +	if (schedstat_enabled() && tg != &root_task_group) {

I put the variables here.

> +		for_each_possible_cpu(i)
> +			ws += schedstat_val(tg->se[i]->statistics.wait_sum);

This doesn't quite work on 32bit archs, but I'm not sure I care enough
to be bothered about that.

> +		seq_printf(sf, "wait_sum %llu\n", ws);
> +	}