linux-kernel - [PATCH 1/1] usb:gadget:function:fix memory leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1532344186-30505-1-git-send-email-wangxidong_97@163.com>
Date:   Mon, 23 Jul 2018 19:09:46 +0800
From:   Xidong Wang <wangxidong_97@....com>
To:     Felipe Balbi <balbi@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Johan Hovold <johan@...nel.org>,
        Michal Nazarewicz <mina86@...a86.com>,
        Vincent Pelletier <plr.vincent@...il.com>
Cc:     wangxidong_97@....com, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: [PATCH 1/1] usb:gadget:function:fix memory leak

In function f_audio_set_alt(), the memory allocated by
usb_ep_alloc_request() is not released on the error path
that req->buf, which holds the return value of kzalloc(),
is NULL. This will result in a memory leak bug.

Signed-off-by: Xidong Wang <wangxidong_97@....com>
---
 drivers/usb/gadget/function/f_uac1_legacy.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/gadget/function/f_uac1_legacy.c b/drivers/usb/gadget/function/f_uac1_legacy.c
index 24c086b..2fcdade 100644
--- a/drivers/usb/gadget/function/f_uac1_legacy.c
+++ b/drivers/usb/gadget/function/f_uac1_legacy.c
@@ -630,8 +630,11 @@ static int f_audio_set_alt(struct usb_function *f, unsigned intf, unsigned alt)
 							ERROR(cdev,
 							"%s queue req: %d\n",
 							out_ep->name, err);
-					} else
+					} else {
+						usb_ep_free_request(
+							out_ep, req);
 						err = -ENOMEM;
+					}
 				} else
 					err = -ENOMEM;
 			}
-- 
2.7.4