linux-kernel - Re: [PATCH v2 13/19] mm/migrate: Use xchg instead of spinlock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180723112032.GH30345@linux.vnet.ibm.com>
Date:   Mon, 23 Jul 2018 04:20:32 -0700
From:   Srikar Dronamraju <srikar@...ux.vnet.ibm.com>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     Ingo Molnar <mingo@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Mel Gorman <mgorman@...hsingularity.net>,
        Rik van Riel <riel@...riel.com>,
        Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH v2 13/19] mm/migrate: Use xchg instead of spinlock

> If you maybe write that like:
> 
> 	if (time_after(jiffies, next_window) &&
> 	    xchg(&pgdat->numabalancing_migrate_nr_pages, 0UL)) {
> 
> 		do {
> 			next_window += interval;
> 		} while (unlikely(time_after(jiffies, next_window)));
> 
> 		WRITE_ONCE(pgdat->numabalancing_migrate_next_window, next_window);
> 	}
> 
> Then you avoid an indent level and line-wrap, resulting imo easier to
> read code.
> 

Okay will do.