linux-kernel - Re: [PATCH] memory: jz4780-nemc: build depend on OF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3660b849-930f-8771-21d7-9f3e63789d13@infradead.org>
Date:   Mon, 23 Jul 2018 08:35:49 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Corentin Labbe <clabbe@...libre.com>, Zubair.Kakakhel@...tec.com,
        gregkh@...uxfoundation.org, alex@...x-smith.me.uk
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] memory: jz4780-nemc: build depend on OF

On 07/23/2018 04:38 AM, Corentin Labbe wrote:
> jz4780-nemc use of_ functions, so it needs to depend on OF
> 
> This fix the following build failure on x86
> drivers/memory/jz4780-nemc.c: In function ‘jz4780_nemc_num_banks’:
> drivers/memory/jz4780-nemc.c:72:10: error: implicit declaration of function ‘of_read_number’ [-Werror=implicit-function-declaration]
> 
> Signed-off-by: Corentin Labbe <clabbe@...libre.com>
> ---
>  drivers/memory/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/memory/Kconfig b/drivers/memory/Kconfig
> index a642552..faa1a23 100644
> --- a/drivers/memory/Kconfig
> +++ b/drivers/memory/Kconfig
> @@ -124,6 +124,7 @@ config JZ4780_NEMC
>  	default y
>  	depends on MACH_JZ4780 || COMPILE_TEST
>  	depends on HAS_IOMEM
> +	depends on OF
>  	help
>  	  This driver is for the NAND/External Memory Controller (NEMC) in
>  	  the Ingenic JZ4780. This controller is used to handle external
> 

Duplicate of https://lore.kernel.org/lkml/20180721200049.7553-1-anders.roxell@linaro.org/


-- 
~Randy