linux-kernel - Re: [PATCH] tracefs: Annotate tracefs_ops with __ro_after

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXu5jJ7jS=ChfVF1oRJsGu-bSXK_WvTs94f_dQ9ud9Bt81-WA@mail.gmail.com>
Date:   Tue, 24 Jul 2018 15:07:18 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Zubin Mithra <zsm@...omium.org>,
        Steven Rostedt <rostedt@...dmis.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Guenter Roeck <groeck@...omium.org>,
        Al Viro <viro@...iv.linux.org.uk>
Subject: Re: [PATCH] tracefs: Annotate tracefs_ops with __ro_after_init

Adding Steven (maintainer) and Al (fs) to CC...

On Tue, Jul 24, 2018 at 1:02 PM, Zubin Mithra <zsm@...omium.org> wrote:
> tracefs_ops is initialized inside tracefs_create_instance_dir and not
> modified after. tracefs_create_instance_dir allows for initialization
> only once, and is called from create_trace_instances(marked __init),
> which is called from tracer_init_tracefs(marked __init).
>
> Signed-off-by: Zubin Mithra <zsm@...omium.org>
> Reviewed-by: Kees Cook <keescook@...omium.org>

Who's tree should this go through?

Thanks!

-Kees

> ---
>  fs/tracefs/inode.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/tracefs/inode.c b/fs/tracefs/inode.c
> index bea8ad876bf9..20e965873f27 100644
> --- a/fs/tracefs/inode.c
> +++ b/fs/tracefs/inode.c
> @@ -53,7 +53,7 @@ static const struct file_operations tracefs_file_operations = {
>  static struct tracefs_dir_ops {
>         int (*mkdir)(const char *name);
>         int (*rmdir)(const char *name);
> -} tracefs_ops;
> +} tracefs_ops __ro_after_init;
>
>  static char *get_dname(struct dentry *dentry)
>  {
> --
> 2.18.0.233.g985f88cf7e-goog
>



-- 
Kees Cook
Pixel Security