linux-kernel - RE: [PATCH V4] mmc: core: improve reasonableness of bus width setting for HS400es

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <155c45c3b69d487ab204398becdaf677@mail2012.asrmicro.com>
Date:   Tue, 24 Jul 2018 05:49:34 +0000
From:   Fang Hongjie(方洪杰) 
        <hongjiefang@...micro.com>
To:     "ulf.hansson@...aro.org" <ulf.hansson@...aro.org>
CC:     "shawn.lin@...k-chips.com" <shawn.lin@...k-chips.com>,
        "adrian.hunter@...el.com" <adrian.hunter@...el.com>,
        "linus.walleij@...aro.org" <linus.walleij@...aro.org>,
        "wsa+renesas@...g-engineering.com" <wsa+renesas@...g-engineering.com>,
        "bst@...gutronix.de" <bst@...gutronix.de>,
        "chanho.min@....com" <chanho.min@....com>,
        "kyle.roeschley@...com" <kyle.roeschley@...com>,
        "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH V4] mmc: core: improve reasonableness of bus width
 setting for HS400es

> mmc_select_hs400es() calls mmc_select_bus_width() which will continue
> to set 4bit transfer mode if fail to set 8bit mode. The bus width
> should not be set to 4bit in HS400es.
> 
> When fail to set 8bit mode, need return error directly for HS400es.
> 
> Signed-off-by: Hongjie Fang <hongjiefang@...micro.com>
> ---
>  drivers/mmc/core/mmc.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c
> index 4466f5d..0dbc512 100644
> --- a/drivers/mmc/core/mmc.c
> +++ b/drivers/mmc/core/mmc.c
> @@ -1338,8 +1338,12 @@ static int mmc_select_hs400es(struct mmc_card *card)
>  		goto out_err;
> 
>  	err = mmc_select_bus_width(card);
> -	if (err < 0)
> +	if (err != MMC_BUS_WIDTH_8) {
> +		pr_err("%s: switch to 8bit bus width failed, err:%d\n",
> +			mmc_hostname(host), err);
> +		err = -EIO;
>  		goto out_err;
> +	}
> 
>  	/* Switch card to HS mode */
>  	err = __mmc_switch(card, EXT_CSD_CMD_SET_NORMAL,
> --
> 1.9.1

Ping.
Any suggestion for it?

B&R
Hongjie