linux-kernel - Re: [PATCH] drm/tegra: hdmi: probe deferral error reporting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 24 Jul 2018 07:55:58 +0200
From:   Marcel Ziswiler <marcel@...wiler.com>
To:     Lucas Stach <dev@...xeye.de>, linux-tegra@...r.kernel.org
CC:     Marcel Ziswiler <marcel.ziswiler@...adex.com>,
        linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        Jonathan Hunter <jonathanh@...dia.com>,
        David Airlie <airlied@...ux.ie>,
        Thierry Reding <thierry.reding@...il.com>
Subject: Re: [PATCH] drm/tegra: hdmi: probe deferral error reporting



On July 23, 2018 10:49:15 PM GMT+02:00, Lucas Stach <dev@...xeye.de> wrote:
>Am Freitag, den 20.07.2018, 09:55 +0200 schrieb Marcel Ziswiler:
>> From: Marcel Ziswiler <marcel.ziswiler@...adex.com>
>> 
>> Actually report the error code from devm_regulator_get() which may as
>> well just be a probe deferral.
>
>This is still noisy, so while you are changing this I would prefer if
>this wouldn't print the error message if it's a simple probe deferral.

Yeah, trust me, I'm not the inventor of this probe deferral disaster!

>Suppressing the log message in that case gets us much cleaner kernel
>logs, where real errors stand out.

Ok, agreed. Will send a v2.

>Regards,
>Lucas
>
>> 
>> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@...adex.com>
>> 
>> ---
>> 
>>  drivers/gpu/drm/tegra/hdmi.c | 10 ++++++----
>>  1 file changed, 6 insertions(+), 4 deletions(-)
>> 
>> diff --git a/drivers/gpu/drm/tegra/hdmi.c
>b/drivers/gpu/drm/tegra/hdmi.c
>> index 0082468f703c..94c182dbb6d0 100644
>> --- a/drivers/gpu/drm/tegra/hdmi.c
>> +++ b/drivers/gpu/drm/tegra/hdmi.c
>> @@ -1693,14 +1693,16 @@ static int tegra_hdmi_probe(struct
>platform_device *pdev)
>>  
>>  	hdmi->hdmi = devm_regulator_get(&pdev->dev, "hdmi");
>>  	if (IS_ERR(hdmi->hdmi)) {
>> -		dev_err(&pdev->dev, "failed to get HDMI regulator\n");
>> -		return PTR_ERR(hdmi->hdmi);
>> +		err = PTR_ERR(hdmi->hdmi);
>> +		dev_err(&pdev->dev, "failed to get HDMI regulator: %d\n", err);
>> +		return err;
>>  	}
>>  
>>  	hdmi->pll = devm_regulator_get(&pdev->dev, "pll");
>>  	if (IS_ERR(hdmi->pll)) {
>> -		dev_err(&pdev->dev, "failed to get PLL regulator\n");
>> -		return PTR_ERR(hdmi->pll);
>> +		err = PTR_ERR(hdmi->pll);
>> +		dev_err(&pdev->dev, "failed to get PLL regulator: %d\n", err);
>> +		return err;
>>  	}
>>  
>>  	hdmi->vdd = devm_regulator_get(&pdev->dev, "vdd");