[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <59fdcf671ffd0ef60e4d982ba269f853089ee7da.camel@baylibre.com>
Date: Tue, 24 Jul 2018 12:03:10 +0200
From: jbrunet@...libre.com
To: Arnd Bergmann <arnd@...db.de>, Mark Brown <broonie@...nel.org>
Cc: Liam Girdwood <lgirdwood@...il.com>,
Carlo Caione <carlo@...one.org>,
Kevin Hilman <khilman@...libre.com>,
alsa-devel@...a-project.org, linux-arm-kernel@...ts.infradead.org,
linux-amlogic@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: meson: axg-spdifout: select SND_PCM_IEC958
On Tue, 2018-07-24 at 11:36 +0200, Arnd Bergmann wrote:
> When CONFIG_SND_PCM_IEC958 is disabled, we get a link error for the
> new driver:
>
> sound/soc/meson/axg-spdifout.o: In function `axg_spdifout_hw_params':
> axg-spdifout.c:(.text+0x650): undefined reference to
> `snd_pcm_create_iec958_consumer_hw_params'
I used arm64 defconfig to do all my test and this symbol was selected
by the HDMI codec driver, which is probably why missed it.
Thanks a lot for fixing the problem Arnd.
>
> The other users use 'select', so we should do the same here.
>
> Fixes: 53eb4b7aaa04 ("ASoC: meson: add axg spdif output")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
Acked-by: Jerome Brunet <jbrunet@...libre.com>
Powered by blists - more mailing lists