linux-kernel - Re: [PATCH] [SUBMITTED 20180724] arm64: fix ACPI dependencies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZ5v0h1zGHrMo6HLtSMWE4kM9YK-3QvgHnBaRrEpMHAJrrMtg@mail.gmail.com>
Date:   Tue, 24 Jul 2018 12:23:48 +0200
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Will Deacon <will.deacon@....com>
Cc:     "Rafael J. Wysocki" <rafael@...nel.org>,
        Arnd Bergmann <arnd@...db.de>,
        AKASHI Takahiro <takahiro.akashi@...aro.org>,
        Ard Biesheuvel <ard.biesheuvel@...aro.org>,
        Catalin Marinas <catalin.marinas@....com>,
        Tony Luck <tony.luck@...el.com>,
        Fenghua Yu <fenghua.yu@...el.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H. Peter Anvin" <hpa@...or.com>,
        "the arch/x86 maintainers" <x86@...nel.org>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Len Brown <lenb@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Marc Zyngier <marc.zyngier@....com>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-ia64@...r.kernel.org,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>
Subject: Re: [PATCH] [SUBMITTED 20180724] arm64: fix ACPI dependencies

On Tue, Jul 24, 2018 at 12:21 PM, Will Deacon <will.deacon@....com> wrote:
> On Tue, Jul 24, 2018 at 11:54:25AM +0200, Rafael J. Wysocki wrote:
>> On Tue, Jul 24, 2018 at 11:48 AM, Arnd Bergmann <arnd@...db.de> wrote:
>> > Kconfig reports a warning on x86 builds after the ARM64 dependency
>> > was added.
>> >
>> > drivers/acpi/Kconfig:6:error: recursive dependency detected!
>> > drivers/acpi/Kconfig:6:       symbol ACPI depends on EFI
>> >
>> > This rephrases the dependency to keep the ARM64 details out of the
>> > shared Kconfig file, so Kconfig no longer gets confused by it.
>> >
>> > For consistency, all three architectures that support ACPI now
>> > select ARCH_SUPPORTS_ACPI in exactly the configuration in which
>> > they allow it. We still need the 'default x86', as each one
>> > wants a different default: default-y on x86, default-n on arm64,
>> > and always-y on ia64.
>> >
>> > Fixes: 5bcd44083a08 ("drivers: acpi: add dependency of EFI for arm64")
>> > Signed-off-by: Arnd Bergmann <arnd@...db.de>
>> > ---
>> > v2: use 'select ARCH_SUPPORTS_ACPI' for all three.
>>
>> LGTM
>>
>> Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
>
> Same here:
>
> Acked-by: Will Deacon <will.deacon@....com>
>
> Would it be ok if I take this via the arm64 tree, since that's where the
> warning was introduced?

Yes, it would, from the ACPI side.