linux-kernel - Re: [PATCH v3 2/3] soc: imx: gpc: clean up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <73b2d272a68ba6a21c62857733f5333a30323fcc.camel@nxp.com>
Date:   Tue, 24 Jul 2018 11:45:23 +0000
From:   Leonard Crestez <leonard.crestez@....com>
To:     "Sven.Schmitt@...ed-mode.de" <Sven.Schmitt@...ed-mode.de>
CC:     dl-linux-imx <linux-imx@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "etnaviv@...ts.freedesktop.org" <etnaviv@...ts.freedesktop.org>,
        Fabio Estevam <fabio.estevam@....com>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "l.stach@...gutronix.de" <l.stach@...gutronix.de>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>
Subject: Re: [PATCH v3 2/3] soc: imx: gpc: clean up

On Tue, 2018-07-24 at 09:46 +0000, Sven Schmitt wrote:
> Remove unused #defines.

This should be the title of the patch, "clean up" is too vague.

> --- a/drivers/soc/imx/gpc.c
> +++ b/drivers/soc/imx/gpc.c
> @@ -24,15 +24,11 @@
>  #define GPC_PGC_CTRL_OFFS	0x0
>  #define GPC_PGC_PUPSCR_OFFS	0x4
>  #define GPC_PGC_PDNSCR_OFFS	0x8
> -#define GPC_PGC_SW2ISO_SHIFT	0x8
> -#define GPC_PGC_SW_SHIFT	0x0

It would be cleaner if you used these defines when reading the sw/iso
values.

>  
>  #define GPC_PGC_PCI_PDN		0x200
>  #define GPC_PGC_PCI_SR		0x20c
>  
>  #define GPC_PGC_GPU_PDN		0x260
> -#define GPC_PGC_GPU_PUPSCR	0x264
> -#define GPC_PGC_GPU_PDNSCR	0x268
>  #define GPC_PGC_GPU_SR		0x26c

Each PGC has a fixed size and layout, maybe we could just have defines
for the offset of the PGC? It would be somewhat similar to gpcv2