linux-kernel - Re: [PATCH 04/12] ASoC: dt-bindings: add dt bindings for wcd9335 audio codec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1f700d0e-57f0-9d9d-cb32-a12c4c4b7243@linaro.org>
Date:   Tue, 24 Jul 2018 12:48:57 +0100
From:   Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
To:     Mark Brown <broonie@...nel.org>
Cc:     lee.jones@...aro.org, robh+dt@...nel.org, mark.rutland@....com,
        lgirdwood@...il.com, tiwai@...e.com, bgoswami@...eaurora.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        vkoul@...nel.org, alsa-devel@...a-project.org
Subject: Re: [PATCH 04/12] ASoC: dt-bindings: add dt bindings for wcd9335
 audio codec



On 24/07/18 12:06, Mark Brown wrote:
> On Mon, Jul 23, 2018 at 04:54:02PM +0100, Srinivas Kandagatla wrote:
>> This patch adds bindings for wcd9335 audio codec which can support both SLIMbus
>> and I2S/I2C interface.
> 
> ...
> 
>> +Qualcomm WCD9335 Codec is a standalone Hi-Fi audio codec IC,
>> +It supports both I2S/I2C and SLIMbus audio interfaces.
> 
> This is a standalone audio CODEC but it also has a MFD binding?  I'd
> have just expected a single binding for a single device.
> 
Thanks for the suggestion!

You are right, I should probably remove the mfd bindings totally.
and move them to codec bindings. And register codec and other blocks 
like soundwire controller as mfd cells. like wm8994.

--srini