linux-kernel - Re: [PATCH v3 1/3] soc: imx: gpc: fix PDN delay

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d30cde038ae7a28bf9264e4e1cc5612f4634e3f5.camel@nxp.com>
Date:   Tue, 24 Jul 2018 11:51:16 +0000
From:   Leonard Crestez <leonard.crestez@....com>
To:     "Sven.Schmitt@...ed-mode.de" <Sven.Schmitt@...ed-mode.de>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>
CC:     "l.stach@...gutronix.de" <l.stach@...gutronix.de>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        Fabio Estevam <fabio.estevam@....com>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        dl-linux-imx <linux-imx@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 1/3] soc: imx: gpc: fix PDN delay

On Tue, 2018-07-24 at 09:46 +0000, Sven Schmitt wrote:
> imx6_pm_domain_power_off() reads iso and iso2sw from
> GPC_PGC_PUPSCR_OFFS 
> which stores the power up delays. 
> So use GPC_PGC_PDNSCR_OFFS for the correct delays.
> 
> Signed-off-by: Sven Schmitt <sven.schmitt@...ed-mode.de>

Reviewed-by: Leonard Crestez <leonard.crestez@....com>

> --- a/drivers/soc/imx/gpc.c
> +++ b/drivers/soc/imx/gpc.c
> @@ -73,7 +73,7 @@ static int imx6_pm_domain_power_off(struct generic_pm_domain *genpd)
>  		return -EBUSY;
>  
>  	/* Read ISO and ISO2SW power down delays */
> -	regmap_read(pd->regmap, pd->reg_offs + GPC_PGC_PUPSCR_OFFS, &val);
> +	regmap_read(pd->regmap, pd->reg_offs + GPC_PGC_PDNSCR_OFFS, &val);
>  	iso = val & 0x3f;
>  	iso2sw = (val >> 8) & 0x3f;